params,core: add max and target value to chain config #31002
Conversation
lightclient
requested review from
holiman,
karalabe,
gballet,
rjl493456442,
zsfelfoldi,
MariusVanDerWijden,
s1na and
jwasinger
as code owners
eth/tracers/internal/tracetest/testdata/prestate_tracer/setcode_tx.json
Outdated
Show resolved
Hide resolved
|
Made the updates from your review, Marius. Thanks! |
| @@ -26,7 +26,7 @@ import ( | |||
| "github.com/holiman/uint256" | |||
| ) | |||
|
|
|||
| var rand = mrand.New(mrand.NewSource(1)) | |||
| var rnd = mrand.New(mrand.NewSource(1)) | |||
There was a problem hiding this comment.
I renamed this because it was playing havoc with my LSP for some reason.
lightclient
force-pushed
the
eip-7840
branch
4 times, most recently
from
5df556c to
c3daabe
Compare
params/config.go
Outdated
| // requested time. | ||
| func (c *ChainConfig) TargetBlobsPerBlock(time uint64) uint64 { | ||
| if c.BlobScheduleConfig == nil { | ||
| panic("blob schedule not defined") |
There was a problem hiding this comment.
Should try to remove these panics and put a check in the fork order checker.
|
|
||
| // CheckConfigBlobSchedule checks that all forks with blobs enabled explicitly | ||
| // define the blob schedule configuration. | ||
| func (c *ChainConfig) CheckConfigBlobSchedule() error { |
There was a problem hiding this comment.
Why is this not in CheckConfigForkOrder? If we introduce another function we have to call it everywhere. This check is also kind of related to the 'fork order', so it would fit perfectly into the other function.
There was a problem hiding this comment.
Yeah I can do this - just thought as I was originally writing it there that it is a different check than checking the fork order. So either needed to change that function's name or create a new one. Could also create a new function like CheckConfig() that calls all methods that verify the config, but does seem a bit overkill. I don't mind adding it back to CheckConfigForkOrder.
| } | ||
|
|
||
| // CalcExcessBlobGas calculates the excess blob gas after applying the set of | ||
| // blobs on top of the excess blob gas. |
There was a problem hiding this comment.
It would be better to enhance the description by adding:
This function assumes that the provided parent header has already passed the London fork.
Implements EIP-7840 and EIP-7691.